- Notifications
You must be signed in to change notification settings - Fork 751
Add credentials environment variables to let ChannelCredentials
and Session
be injected #4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated Show resolved Hide resolved
I'm realizing there's 3 ways to do this in the exporters:
I'm going forward with #2 since that's simplest for both the user and the entry point provider. So the function signature that gets associated w/ the entry point should look like:
|
...etry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py Outdated Show resolved Hide resolved
...etry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py Outdated Show resolved Hide resolved
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py Outdated Show resolved Hide resolved
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py Outdated Show resolved Hide resolved
…__init__.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>
…ry-python into add_cred_envvar
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused by the tox.ini changes but lgtm
Yeah I'm having issues w/ pytest in the venv created by tox.. It is supposedly installed by the test, but I get the following error If I then run |
Does it pass CI on Github if you just revert those files back to |
yeah it works. reverted the change |
Description
Add environment variables to allow
ChannelCredentials
andSession
to be injected into OTLP exporters for auto instrumentation. See #4459 for more details..Fixes # 4459
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: