OTEL attribute count limit not respected, causing columns dropped

[giongto35]

Description

Fixes #4671

This PR fixes a bug where the LoggingHandler in the OpenTelemetry Python SDK does not respect the OTEL_ATTRIBUTE_COUNT_LIMIT environment variable. When this environment variable is set, it should limit the number of attributes in log records, but the LoggingHandler was ignoring this setting entirely and only use the default value 128.
It means:

• If we set to small count limit like 3, logging 10 attributes still works without any attributes dropped.
• If we set to high count limit like 256, logging 200 attributes has (200-128= 72) attributes dropped.

Changes Made

Fixed the Root Cause Bug

The core issue was that LogRecord was created with _UnsetLogLimits which used UNSET values, and the LogLimits._from_env_if_absent method had a bug where it returned None immediately when value == cls.UNSET, never checking environment variables.

# Before (buggy): _UnsetLogLimits = LogLimits(max_attributes=LogLimits.UNSET, ...) # This caused _from_env_if_absent to return None immediately without reading env vars # After (fixed): # Removed _UnsetLogLimits entirely, now use None as default limits = limits or LogLimits() # LogLimits() correctly reads from env vars

Implementation Benefits

This implementation allows users to:

• Rely on environment variables for configuration (OTEL_ATTRIBUTE_COUNT_LIMIT)
• Use a cleaner, more intuitive API without special UNSET values

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Code refactoring (improves code quality without changing functionality)

How Has This Been Tested?

You can run the tests using pytest:

# Install the package in development mode pip install -e . # Run all the LoggingHandler tests pytest opentelemetry-sdk/tests/logs/test_handler.py -v # Run all logging tests pytest opentelemetry-sdk/tests/logs/ -v # Run only the attribute count limit tests pytest opentelemetry-sdk/tests/logs/test_handler.py::TestLoggingHandler -k "otel_attribute_count_limit" -v

Test Coverage

Added comprehensive tests to verify the fix works correctly:

1. test_otel_attribute_count_limit_respected_in_logging_handler - Tests that when OTEL_ATTRIBUTE_COUNT_LIMIT=3, only 3 attributes are kept and the rest are dropped
2. test_otel_attribute_count_limit_includes_code_attributes - Tests that when OTEL_ATTRIBUTE_COUNT_LIMIT=5, only 5 attributes are kept and the limit applies to all attribute types including code attributes
3. test_logging_handler_without_env_var_uses_default_limit - Tests that without the environment variable, the default limit of 128 is applied

All tests pass, confirming the fix works correctly across all these scenarios.

Does This PR Require a Contrib Repo Change?

• No.

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated
• Fixed the original bug with OTEL_ATTRIBUTE_COUNT_LIMIT
• Refactored code for better maintainability
• Removed deprecated/unnecessary code patterns
• All existing tests continue to pass

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: giongto35 / name: giongto35 (1685cb0, 835f632, dd539f5, 0ac986f, d2ac2c3, 36d5cc2, 404fffb, a0adda0, df9af37, eb3b8d9)
• ✅ login: emdneto / name: Emídio Neto (191e937)
• ✅ login: xrmx / name: Riccardo Magliocchetti (e630c14, d56a61c, 2cf133d)

[yurishkuro]

reverting my approval pending https://github.com/open-telemetry/opentelemetry-python/pull/4677/files#r2198591904

[giongto35]

Hi @pmcollins , can this change be merged so we can patch our code?

[pmcollins]

Hi @pmcollins , can this change be merged so we can patch our code?

Hi @giongto35 -- we'll need one of the maintainers to review the change. Once a maintainer has approved, then the change can be merged.

In the meantime, I have approved the workflows to run.

[giongto35]

Hi @aabmass @ocelotl @lzchen @xrmx , can anyone of you from maintainers can help me merge this change? Appreciate it.

[yurishkuro]

@giongto35 avoid merging main unless there are conflicts, doing so just resets the CI checks and wastes maintainers' time as they need to re-approve CI runs.

[giongto35]

I see some failures in the checks https://github.com/open-telemetry/opentelemetry-python/pull/4677/checks . Is there anything I need to do to get it merged
"opentelemetry-sdk/tests/logs/test_handler.py:39:0: R0904: Too many public methods (21/20) (too-many-public-methods)"
Seems I needs to reduce number of tests

and @aabmass @ocelotl @lzchen @xrmx please help merge the change if it is ready, it is breaking our production.

[giongto35]

Ping @aabmass @ocelotl @lzchen @xrmx . It is breaking our production so we hope the issue is addressed ASAP. What is the ETA for this fix to be merged?

[xrmx]

@giongto35 please fix linting failures (fine to add annotation to ignore the pylint error) and add a changelog entry