Relax protobuf version requirement to support v6 #4620
Conversation
emdneto left a comment
emdneto left a comment There was a problem hiding this comment.
Does tests pass for newer versions?
| @emdneto I think running the workflows requires approval, are you able to do that? |
| I am not the maintainer or even contributor, but based on the upgrading flow to The statement appeared in this issue/comment: #3958 (comment) |
Yes, I think this is the general agreement from the SIG. @bouk I mean, update the test-requirements.txt and run the tests. |
| @emdneto done, and the tests pass |
| Hi team, I don't know if you are aware of this https://nvd.nist.gov/vuln/detail/CVE-2025-4565 |
emdneto left a comment
emdneto left a comment There was a problem hiding this comment.
@bouk, we’ll need to create two test-requirements files—one with proto5 and one with proto6—and do the same for components that use opentelemetry-proto, such as exporters. Do you have bandwidth for this? Lmk if not, and I can push the changes to your branch to get this reviewed and merged.
| I have time for this tomorrow, sure. |
This is no longer relevant see my comment on #4639 (comment). This PR looks is the correct approach |
Did you already start on this? If not, I already have a fix I can push. |
This uncovered some incompatibilty with oldest versions listed in pyproject.toml which I fixed.
| @emdneto PTAL, I added separate tox targets for oldest+latest supported dependencies for |
| Please someone push a changelog :) |
xrmx moved this from Reviewed PR that needs fixing to Ready for review in @xrmx's Python PR digest 
github-project-automation bot moved this from Ready for review to Done in @xrmx's Python PR digest 
| Hello everyone! Is this scheduled for release? If so, is there an ETA? I could take advantage of this fix Thanks in advance! |
9 participants
Fixes #4563, see that issue for details