Fix invalid type: ignore that causes mypy to ignore the whole file #4618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aabmass force-pushed the pyright-deprecated-fix branch from ba6673d to c317fd5 Compare 
xrmx approved these changes Jun 6, 2025
xrmx pushed a commit to xrmx/opentelemetry-python that referenced this pull request Jun 10, 2025
xrmx pushed a commit that referenced this pull request Jun 10, 2025
unflxw added a commit to appsignal/appsignal-python that referenced this pull request Jun 10, 2025
This commit reverts 3cfb695 -- the underlying cause was [a bug in the previous OpenTelemetry release][bug] that has been [fixed in the latest release][fix] [bug]: open-telemetry/opentelemetry-python#4615 (comment) [fix]: open-telemetry/opentelemetry-python#4618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4615
Explanation in #4615 (comment). Let's backport this into the patch release we're planning for next week.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested against the repro in #4615 with mypy.
Success: no issues found in 1 source fileDoes This PR Require a Contrib Repo Change?
Checklist: