Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…-python into refactor_blrp
xrmx reviewed Apr 29, 2025
opentelemetry-sdk/tests/shared_internal/test_batch_processor.py Outdated Show resolved Hide resolved
xrmx reviewed Apr 30, 2025
Contributor Author
| Nevermind.. was able to get the test working |
xrmx approved these changes May 6, 2025
aabmass reviewed May 8, 2025
Member
aabmass left a comment
aabmass left a comment There was a problem hiding this comment.
Nice, just a few comments on design and typing
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py Outdated Show resolved Hide resolved
lzchen approved these changes May 12, 2025
…nto refactor_blrp
aabmass approved these changes May 12, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py Outdated Show resolved Hide resolved
github-project-automation bot moved this from Ready for review to Done in @xrmx's Python PR digest 
mxiamxia pushed a commit to aws-observability/aws-otel-python-instrumentation that referenced this pull request Oct 30, 2025
…58b0 (#524) This PR updates the upstream OpenTelemetry Python dependency to its September 2025 release; Upgrading from version 1.33.1/0.54b1 to 1.37.0/0.58b0. It also resolves several conflicts between the following OTel PRs and existing ADOT patches: starlette: Remove maximum version constraint open-telemetry/opentelemetry-python-contrib#3456 Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use open-telemetry/opentelemetry-python#4562 Make exporter timeout encompass retries/backoffs, add jitter to backoffs, cleanup code a bit open-telemetry/opentelemetry-python#4564 Update BatchSpanProcessor to use new BatchProcessor class open-telemetry/opentelemetry-python#4580 Fix issue where deadlock can occur over logging._lock open-telemetry/opentelemetry-python#4636 Tests Performed tox -e lint tox -e spellcheck tox -e 3.9-test-aws-opentelemetry-distro tox -e 3.10-test-aws-opentelemetry-distro tox -e 3.11-test-aws-opentelemetry-distro tox -e 3.12-test-aws-opentelemetry-distro tox -e 3.13-test-aws-opentelemetry-distro Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Make a
BatchProcessorclass which bothBatchSpanRecordProcessorandBatchLogRecordProcessorcan use.Move
BatchProcessorinto a new_shared_internalfolder in the SDK, so both processors can make use of it.In a follow up PR, I will update
BatchSpanRecordProcessorto use this new class.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added unit tests
Does This PR Require a Contrib Repo Change?
Checklist: