Update google genai instrumentation to work with latest semantic convention, allow for uploading content. #3772
+2,399 −901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
aabmass reviewed Sep 23, 2025
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
argaj force-pushed the genai-instrumentation-semconv branch from e76d888 to d0d6f1a Compare 
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
argaj force-pushed the genai-instrumentation-semconv branch from d0d6f1a to ee911f5 Compare argaj force-pushed the genai-instrumentation-semconv branch from 5d0572a to 8583327 Compare argaj changed the title 
DylanRussell reviewed Oct 1, 2025
...-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/instrumentor.py Outdated Show resolved Hide resolved
aabmass reviewed Oct 6, 2025
...lemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/flags.py Show resolved Hide resolved
DylanRussell reviewed Oct 6, 2025
...metry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/message.py Outdated Show resolved Hide resolved
...metry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/message.py Show resolved Hide resolved
| interactions: | ||
| - request: | ||
| body: |- | ||
| { |
There was a problem hiding this comment.
Mind adding a test for the completion hook somewhere ? https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/test_function_calling_experimental.py#L262 -- this is how I did it for vertex AI
DylanRussell reviewed Oct 6, 2025
instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/requirements.oldest.txt Show resolved Hide resolved
…y-python-contrib into genai-instrumentation-semconv
aabmass approved these changes Oct 9, 2025
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...entation-genai/opentelemetry-instrumentation-google-genai/tests/generate_content/test_e2e.py Show resolved Hide resolved
...rate_content/cassettes/test_streaming[excludecontent-gemini-2.5-flash-vertexaiapi-sync].yaml Outdated Show resolved Hide resolved
...ate_content/cassettes/test_streaming[excludecontent-gemini-2.5-flash-vertexaiapi-async].yaml Outdated Show resolved Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated Show resolved Hide resolved
DylanRussell reviewed Oct 9, 2025
...ation-genai/opentelemetry-instrumentation-google-genai/tests/utils/test_tool_call_wrapper.py Show resolved Hide resolved
...metry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/message.py Show resolved Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py Outdated Show resolved Hide resolved
...rate_content/cassettes/test_streaming[excludecontent-gemini-2.5-flash-vertexaiapi-sync].yaml Outdated Show resolved Hide resolved
DylanRussell approved these changes Oct 10, 2025
…y-python-contrib into genai-instrumentation-semconv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Accomodation of semantic conventions changes made in open-telemetry/semantic-conventions#2179.
Also, when logging the completion details, the upload hook is called, so if user has configured
OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATHandOTEL_INSTRUMENTATION_GENAI_UPLOAD_HOOKenv vars, completion details will also be logged as refs (if appropriate capture content env var is set).Type of change
How Has This Been Tested?
Unit tests, manual tests.
Does This PR Require a Core Repo Change?
No
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.