Skip to content

missing capture_parameters in instrumentation psycopg #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 10, 2025
Merged

missing capture_parameters in instrumentation psycopg #3676

merged 7 commits into from
Oct 10, 2025
+41 −0

Conversation

StefanoOvus
Copy link
Contributor

@StefanoOvus StefanoOvus commented Aug 5, 2025 •
edited
Loading

Description

Added missing parameter capture_parameters for psycopg instrumentation:

PsycopgInstrumentor().instrument(capture_parameters=True)

populates the db.statement.parameters attribute in spans.

Fixes #3569

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added tests for sync and async connection:

  • instrumentation/opentelemetry-instrumentation-psycopg/tests/test_psycopg_integration.py::TestPostgresqlIntegration::test_span_params_attribute
  • instrumentation/opentelemetry-instrumentation-psycopg/tests/test_psycopg_integration.py::TestPostgresqlIntegrationAsync::test_span_params_attribute

Tested in a small script with Python 3.13.3 + jaegertracing/jaeger:2.6.0 docker image (OTLP/gRPC protocol).

  • tox -e py313-test-instrumentation-psycopg
  • tox -e spellcheck
  • tox -e lint-instrumentation-psycopg

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Aug 22, 2025
xrmx
xrmx reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a CHANGELOG entry
@StefanoOvus StefanoOvus force-pushed the psycopg-instrumentation-capture-params branch from b30ad9c to 6eabb29 Compare August 25, 2025 15:22
@StefanoOvus StefanoOvus requested a review from a team as a code owner August 25, 2025 15:34
@StefanoOvus
Copy link
Contributor Author

@xrmx added changelog as requested.
@xrmx xrmx moved this from Ready for review to Easy to review / merge / close in @xrmx's Python PR digest Aug 28, 2025
@xrmx
Copy link
Contributor

xrmx commented Aug 29, 2025 •
edited
Loading

@StefanoOvus please run tox -e ruff and commit the fixes
@StefanoOvus StefanoOvus force-pushed the psycopg-instrumentation-capture-params branch from 8f6bd0d to ec2d85b Compare September 22, 2025 09:54
@StefanoOvus
Copy link
Contributor Author

@StefanoOvus please run tox -e ruff and commit the fixes

@xrmx done
@tammy-baylis-swi
Copy link
Contributor

There is a typecheck failure but I don't think it's related to changes made in this PR:

typecheck: commands[0]> pyright /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/span_manager.py /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/span_manager.py:34:5 - error: Type of "children" is partially unknown Type of "children" is "list[Unknown]" (reportUnknownVariableType) 1 error, 0 warnings, 0 informations
tammy-baylis-swi
tammy-baylis-swi reviewed Sep 22, 2025
View reviewed changes
tammy-baylis-swi
tammy-baylis-swi approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
@StefanoOvus StefanoOvus force-pushed the psycopg-instrumentation-capture-params branch from ec2d85b to b99746f Compare September 23, 2025 14:31
@StefanoOvus StefanoOvus force-pushed the psycopg-instrumentation-capture-params branch from b99746f to 78a56d1 Compare September 29, 2025 14:13
@xrmx xrmx enabled auto-merge (squash) October 10, 2025 13:32
@xrmx xrmx merged commit 302ffe2 into open-telemetry:main Oct 10, 2025
638 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in @xrmx's Python PR digest Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@StefanoOvus @xrmx @tammy-baylis-swi