- Notifications
You must be signed in to change notification settings - Fork 789
Add redis client only instrumentation #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xrmx merged 33 commits into open-telemetry:main from OlegZv:add_redis_client_only_instrumentation May 9, 2025
Merged
Changes from all commits
Commits
Show all changes
33 commits Select commit Hold shift + click to select a range
2c291bf
Rough draft of the contribution
OlegZv c33f2b5
Add connection instrumentation based on the existing pattern.
OlegZv 1f99507
fix tests to use fake redis
OlegZv edca781
replace the redis version checks with defines
OlegZv be3ca10
Adjust comment and fix one test
OlegZv 0918232
Update documentation with the client method
OlegZv 843e708
Update the changelog
OlegZv c169b85
Update the HTTPX readme to point to proper class method
OlegZv a94d8ec
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 3a9f1d1
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 06eb8c5
Add back the assert_span_count method
OlegZv de415e2
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 1ababf2
Move the changelog update to the unreleased section
OlegZv 74395a8
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 04adec4
Remove extra whitespace in the Changelog
OlegZv 31a8b4b
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv cf134ea
Fix linter complaints
OlegZv 3f8ca64
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 2d901c9
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv cf88331
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 533b8a1
Remove hasattr assert
OlegZv 0fa915b
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 9032990
Merge branch 'main' into add_redis_client_only_instrumentation
xrmx 86c34cd
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 20b9bc8
Move the Changelog to Unreleased
OlegZv 69ca5cf
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 4c1d7e3
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv d2c4fb7
Merge branch 'main' into add_redis_client_only_instrumentation
OlegZv 586a87a
Review comments. Move types to types.py, move some functions to util.…
OlegZv 9b77998
Fix type compatibility
OlegZv 5734cd0
Merge branch 'main' into add_redis_client_only_instrumentation
xrmx 0ee8358
Merge branch 'main' into add_redis_client_only_instrumentation
emdneto 0abbaee
fix typing and lint
OlegZv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
OpenTelemetry Redis Instrumentation | ||
=================================== | ||
.. include:: ../../../instrumentation/opentelemetry-instrumentation-redis/README.rst | ||
OlegZv marked this conversation as resolved. Show resolved Hide resolved | ||
:end-before: References | ||
| ||
Usage | ||
----- | ||
| ||
.. automodule:: opentelemetry.instrumentation.redis | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
:show-inheritance: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.