Extract a full context (e.g. baggage) in aiohttp-server instrumentation #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Before, only a parent span was extracted, any other cross-cutting context extracted from the message would be dropped on the floor. Instead, attach the full context extracted for the duration of the call. This uses the `_start_internal_or_server_span` helper function as used in e.g. flask.
Contributor
| @Dr-Emann please fix lint and conflicts |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Before, only a parent span was extracted, any other cross-cutting context extracted from the message would be dropped on the floor. Instead, attach the full context extracted for the duration of the call.
This uses the
_start_internal_or_server_spanhelper function as used in e.g. flask.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.