Skip to content

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Oct 6, 2025

Collection of some host-metrics metrics can be costly. Using a Metrics View can be used
to drop metrics, but there will still be the cost of having collected them in the
first place. This adds a config option to select which groups of metrics should
be collected.

Checklist

  • tests
trentm added 2 commits October 6, 2025 14:02
… which metrics are collected Collection of some host-metrics metrics can be costly. Using a Metrics View can be used to drop metrics, but there will still be the cost of having collected them in the first place. This adds a config option to select which groups of metrics should be collected.
@trentm trentm changed the title feat(host-metrics): add 'metricsGroups' configuration option to limit which metrics are collected feat(host-metrics): add 'metricGroups' configuration option to limit which metrics are collected Oct 6, 2025
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@trentm trentm marked this pull request as ready for review October 15, 2025 23:08
@trentm trentm requested a review from a team as a code owner October 15, 2025 23:08
@trentm trentm requested a review from legendecas October 16, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants