chore(lint): switch from 'header' to 'license-header' eslint plugin #2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| "allowedHeaderPatterns": [ | ||
| // Allow additional copyrights on the first line. | ||
| /^\/\*\r?\n \* Copyright The OpenTelemetry Authors(, .+)*\r?\n \*\r?\n \* Licensed under the Apache License, Version 2.0 \(the "License"\);\r?\n \* you may not use this file except in compliance with the License.\r?\n \* You may obtain a copy of the License at\r?\n \*\r?\n \* https:\/\/www.apache.org\/licenses\/LICENSE-2.0\r?\n \*\r?\n \* Unless required by applicable law or agreed to in writing, software\r?\n \* distributed under the License is distributed on an "AS IS" BASIS,\r?\n \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r?\n \* See the License for the specific language governing permissions and\r?\n \* limitations under the License.\r?\n \*\/$/, |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #2969 +/- ## ========================================== + Coverage 89.79% 89.84% +0.04% ========================================== Files 188 188 Lines 9222 9272 +50 Branches 1900 1901 +1 ========================================== + Hits 8281 8330 +49 - Misses 941 942 +1
🚀 New features to boost your workflow:
|
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Sep 12, 2025
…cense headers This changes to a new eslint-plugin to handle license headers. It supports the configurability that we need to allow additional Copyright holders. I've manually adapted the Copyright positioning in instr-oracledb and resource-detector-gcp to conform with the defined license header pattern. We can adjust the regexp if we need. Refs: open-telemetry#2969
| Obsoleted by the work in #3001 -- we are now using https://github.com/trentm/eslint-plugin-yet-another-license-header, which is effectively the license-header eslint plugin functionality with the added fix that I was trying to upstream. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #2967
Refs: nikku/eslint-plugin-license-header#26
checklist
This is still in draft because it is incomplete. The current
license-headereslint plugin won't suffice until nikku/eslint-plugin-license-header#26 or similar functionality is added to it. This is because the license header for this repo allows for some variance. Currentlylicense-headerrequired a single version.license-headerlicense-headeris acceptable