- Notifications
You must be signed in to change notification settings - Fork 500
[API] Add synchronous gauge #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits Select commit Hold shift + click to select a range
63fa75e
Add synchronous gauge
uuzay 095435a
Add ABI Version macro, update tests
uuzay bd8cb23
Fix function description
uuzay eecf89f
Fix formatting
uuzay 60df532
Remove ABI macros from SDK.
uuzay 855f86d
Add error log for gauge delta temporality.
uuzay f84a896
Fix formatting
uuzay c9e40a5
Merge branch 'main' into sync_gauge_2279
uuzay 55afe83
Merge branch 'main' into sync_gauge_2279
lalitb 56bdf77
Apply suggestions from code review
marcalff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
| @@ -247,5 +247,82 @@ class UpDownCounter : public SynchronousInstrument | |
} | ||
}; | ||
| ||
#if OPENTELEMETRY_ABI_VERSION_NO >= 2 | ||
/* A Gauge instrument that records values. */ | ||
template <class T> | ||
class Gauge : public SynchronousInstrument | ||
{ | ||
| ||
public: | ||
/** | ||
* Record a value | ||
* | ||
* @param value The measurement value. May be positive, negative or zero. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not blocking the merge. Seems
| ||
*/ | ||
virtual void Record(T value) noexcept = 0; | ||
| ||
/** | ||
* Record a value | ||
* | ||
* @param value The measurement value. May be positive, negative or zero. | ||
* @param context The explicit context to associate with this measurement. | ||
*/ | ||
virtual void Record(T value, const context::Context &context) noexcept = 0; | ||
| ||
/** | ||
* Record a value with a set of attributes. | ||
* | ||
* @param value The measurement value. May be positive, negative or zero. | ||
* @param attributes A set of attributes to associate with the value. | ||
*/ | ||
| ||
virtual void Record(T value, const common::KeyValueIterable &attributes) noexcept = 0; | ||
| ||
/** | ||
* Record a value with a set of attributes. | ||
* | ||
* @param value The measurement value. May be positive, negative or zero. | ||
* @param attributes A set of attributes to associate with the value. | ||
* @param context The explicit context to associate with this measurement. | ||
*/ | ||
virtual void Record(T value, | ||
const common::KeyValueIterable &attributes, | ||
const context::Context &context) noexcept = 0; | ||
| ||
template <class U, | ||
nostd::enable_if_t<common::detail::is_key_value_iterable<U>::value> * = nullptr> | ||
void Record(T value, const U &attributes) noexcept | ||
{ | ||
this->Record(value, common::KeyValueIterableView<U>{attributes}); | ||
} | ||
| ||
template <class U, | ||
nostd::enable_if_t<common::detail::is_key_value_iterable<U>::value> * = nullptr> | ||
void Record(T value, const U &attributes, const context::Context &context) noexcept | ||
{ | ||
this->Record(value, common::KeyValueIterableView<U>{attributes}, context); | ||
} | ||
| ||
void Record(T value, | ||
std::initializer_list<std::pair<nostd::string_view, common::AttributeValue>> | ||
attributes) noexcept | ||
{ | ||
this->Record(value, nostd::span<const std::pair<nostd::string_view, common::AttributeValue>>{ | ||
attributes.begin(), attributes.end()}); | ||
} | ||
| ||
void Record( | ||
T value, | ||
std::initializer_list<std::pair<nostd::string_view, common::AttributeValue>> attributes, | ||
const context::Context &context) noexcept | ||
{ | ||
this->Record(value, | ||
nostd::span<const std::pair<nostd::string_view, common::AttributeValue>>{ | ||
attributes.begin(), attributes.end()}, | ||
context); | ||
} | ||
}; | ||
#endif | ||
| ||
} // namespace metrics | ||
OPENTELEMETRY_END_NAMESPACE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.