Add Screen-orientation instrumentation module

[RiyazurRazak]

Resolves #932

[RiyazurRazak]

• Api Dump

[codecov]

Codecov Report

❌ Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.02%. Comparing base (d27f9a4) to head (8e0574e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
.../instrumentation/ScreenOrientationConfiguration.kt	0.00%	8 Missing ⚠️
...sl/instrumentation/InstrumentationConfiguration.kt	25.00%	3 Missing ⚠️
...ion/screenorientation/ScreenOrientationDetector.kt	80.00%	2 Missing and 1 partial ⚠️
...eenorientation/ScreenOrientationInstrumentation.kt	91.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@ ## main #1333 +/- ## ========================================== - Coverage 64.12% 64.02% -0.10%  ========================================== Files 154 157 +3 Lines 3063 3099 +36 Branches 316 318 +2 ========================================== + Hits 1964 1984 +20  - Misses 1009 1022 +13  - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[breedx-splk]

@RiyazurRazak thanks for the PR! It's exciting to see the instrumentation coverage expanding like this!

I want to request two changes:

First, can we remove the additional extractors? I know you're following a pattern that seems to exist elsewhere, but I think those other cases have specific uses in mind. In the case here, the Orientation class only has one field (value), so there is really no use case to having additional extractors (there's basically nothing they can do).

Second, let's work on tweaking the shape of the event. I think we should remove the body text entirely (it is redundant), and we should add an attribute that contains the orientation. Because I think there is not yet semantic convention for this, we have some wiggle room, but something like screen.orientation might be a reasonable starting key, and the value should be a string (portrait or landscape) because other systems (ios, web) may not have the same constants available, and it's more useful to have the strings.

There's also some merge conflicts that will need resolving/rebasing.

Thanks again!

[RiyazurRazak]

Thanks for the feedback, @breedx-splk. I’ll update the Event structure accordingly and remove the extractors.

[LikeTheSalad]

Thank you for your contribution! I think it's a great start, I just left a couple of comments.

[LikeTheSalad]

I think we don't need this file.

[LikeTheSalad]

If we need to check whether some field is initialized or not, I prefer to make them nullable instead of resorting to the isInitialized check.

[LikeTheSalad]

Please add the dependency coordinates, in case someone isn't using the agent. This is an example of how we've added it to other instrumentations.

[breedx-splk]

Nice, thanks for following up. I think @LikeTheSalad has some good feedback as well, but I think we're close to a great start. I'd love to see the corresponding semantic conventions PR as well. Cheers!

[LikeTheSalad]

Thank you! 🙏