Run-as-root env vars in orterun.c #6895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can one of the admins verify this patch? |
Member
| ok to test |
Member
| @simonbyrne Per our contribution guidelines, can you sign-off your commit? Thanks. |
I found that I needed to apply the same change as open-mpi#5597 to orterun.c for the environment variables to work correctly. Signed-off-by: Simon Byrne <simonbyrne@gmail.com>
Contributor Author
| @jsquyres done. |
Member
| @simonbyrne Thanks for updating. Gotta say -- this is a little surprising that for the amount of noise that was made over this feature, no one noticed this issue for a year. |
Contributor
| @simonbyrne Might want to cherry-pick this to the v4.0.x branch |
jsquyres added a commit to jsquyres/ompi that referenced this pull request Aug 19, 2019
open-mpi#6895 fixed the code in orterun.c to allow running as root if both OMPI_ALLOW_RUN_AS_ROOT and OMPI_ALLOW_RUN_AS_ROOT_CONFIRM env vars are set. However, this env-var-checking code already exists in orte_submit.c:orte_submit_init() -- it looks like the geteuid()/getenv()-checking code here in orterun is now duplicate code. So let's just get rid of the duplicate code. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Member
jsquyres added a commit to jsquyres/ompi that referenced this pull request Aug 19, 2019
open-mpi#6895 fixed the code in orterun.c to allow running as root if both OMPI_ALLOW_RUN_AS_ROOT and OMPI_ALLOW_RUN_AS_ROOT_CONFIRM env vars are set. However, this env-var-checking code already exists in orte_submit.c:orte_submit_init() -- it looks like the geteuid()/getenv()-checking code here in orterun is now duplicate code. So let's just get rid of the duplicate code. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 197beb3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I found that I needed to apply the same change as #5597/#5598 to orterun.c for the environment variables to work correctly.