Need to signal -pgrp to get to all members of a process group. #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Thanks to Ted Sussman for the report and patience in tracking it down Signed-off-by: Ralph Castain <rhc@open-mpi.org>
| Interesting. We found a similar issue and fixed it differently in PR #3337 - Note that PR was not accepted in whole. I like the technique used this this PR though. - kill_local(cd->child->pid, SIGKILL); + + /* Send signal to the negative of the PID to send the signal to all + * of the children of that PID - the process group under it. + * Otherwise it is delivered to only that PID. + */ + kill_local(cd->child->pid * -1, SIGKILL); + |
This was referenced Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thanks to Ted Sussman for the report and patience in tracking it down
Signed-off-by: Ralph Castain rhc@open-mpi.org