Resolve a race condition for setting our working directory when fork/exec'ing application procs. #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…exec'ing application procs. We have to ensure we do it after the fork occurs since we want to use multiple threads in the odls. Otherwise, the different threads are bouncing the entire process around. Signed-off-by: Ralph Castain <rhc@open-mpi.org>
| @rhc54 Looks like something went wrong in the alps module (per the "LANL-CI" results). |
| I'm trying to replicate that right now on gadget, but can't - it looks like everything compiles fine over there. Still trying to figure it out |
| Something is really screwed up in LANL's Jenkins - the orte/odls/alps component is the pre-change one, even though everything else is correctly updated by the PR. That's why it is breaking. I'll try it again in case there is something weird here. bot:lanl:retest |
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have to ensure we do it after the fork occurs since we want to use multiple threads in the odls. Otherwise, the different threads are bouncing the entire process around.
Signed-off-by: Ralph Castain rhc@open-mpi.org