avoid data race on set LASTUSED attribute #13423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
naughtont3 force-pushed the tjn-fixdatarace-lastused branch from 23f59ad to 30120f5 Compare 
Avoid possible data race that could result in off-by-one issue when setting MPI_LASTUSEDCODE attribute during MPI_Add_error_{class,code} or MPI_Remove_error_{class,code}. Addresses coverity CID 1666426, 1666427 (missing_lock) Also includes some formatting cleanup in files. Signed-off-by: Thomas Naughton <naughtont@ornl.gov> naughtont3 force-pushed the tjn-fixdatarace-lastused branch from af6f0f7 to 6d3ee24 Compare 
Contributor Author
| note to self: todo - double check can not get less than lastcode on return from remove_errcode/errclass that would cause caller to put bogus value for attribute. |
Signed-off-by: Thomas Naughton <naughtont@ornl.gov>
Contributor Author
| @jsquyres This should resolve Coverity issues and fix a bug found while testing with thread-multiple |
Contributor Author
| https://github.com/open-mpi/ompi-tests-public/tree/master/environ-mgmt |
Contributor Author
| @hppritcha can you review this change, good to have before 6.0 branch. |
hppritcha approved these changes Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Avoid possible data race that could result in off-by-one issue when setting MPI_LASTUSEDCODE attribute after during MPI_Add_error_{class,code} or MPI_Remove_error_{class,code}.
Addresses coverity CID 1666426, 1666427 (missing_lock)
Also includes some formatting cleanup in files.