Skip to content

Conversation

rakhmets
Copy link
Contributor

Set mode local id hint for UCX context.
The parameter is introduced by openucx/ucx#10870.
The parameter does not affect semantics, only transport selection criteria and the resulting performance.

Signed-off-by: Raul Akhmetshin <rakhmetshin@nvidia.com>
Copy link
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosilca
Copy link
Member

bosilca commented Sep 22, 2025

I'm really curious about how this can improve performance ? What assumptions are made about the rank that lead to better performance ?

@brminich
Copy link
Member

I'm really curious about how this can improve performance ? What assumptions are made about the rank that lead to better performance ?

for instance we use it to support certain server configurations here
openucx/ucx#10870

@brminich brminich marked this pull request as ready for review September 24, 2025 08:03
@rhc54
Copy link
Contributor

rhc54 commented Sep 24, 2025

Just FWIW: if you think you might want to support dynamic operations (e.g., comm_spawn) or permit multiple jobs to share a node (e.g., when using a workload manager), then you might want to use the node rank of the process instead of the local rank to ensure each proc has a unique value. If only one job is executing, or if the environment fails to provide the node rank, then the local and node ranks are the same.

@brminich brminich merged commit 20d0968 into open-mpi:main Sep 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

6 participants