MPI_T_Events: but wait there is more! #13197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Turns out I forgot to run the pcvs checker when adding MPI_T event stubs in PR open-mpi#13086 and missed a couple of events related functions. Also it looks like these were not included in PR open-mpi#8057. With this patch, the PCVS MPI API checker passes for MPI 4.0 standard. The PCVS MPI API checker is described here https://dl.acm.org/doi/abs/10.1145/3615318.3615329 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
jsquyres approved these changes Apr 21, 2025
Member
jsquyres left a comment
jsquyres left a comment There was a problem hiding this comment.
Did we specify anywhere in the docs that the MPI_T implementation is currently a shell / will always return 0 events?
| | ||
| #include <mpi.h> | ||
| | ||
| int MPI_T_category_get_events(int cat_index, int len, int indices[]) |
Member
There was a problem hiding this comment.
We'll need to update this PR or #13179, depending on who merges first (i.e., generate the bindings that appear in the man pages).
Member Author
| No we havent. Per discussion today we can first add a blurb to the relevant man Pages. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Turns out I forgot to run the pcvs checker when adding MPI_T event stubs in PR #13086 and missed a couple of events related functions. Also it looks like these were not included in PR #8057.
With this patch, the PCVS MPI API checker passes for MPI 4.0 standard.
The PCVS MPI API checker is described here https://dl.acm.org/doi/abs/10.1145/3615318.3615329