coll/xhc: Fix MCA var related segfault with sessions #13024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The MCA subsystem clears the storage of string variables at de-init. Keep our defaults in a secondary structure, so they remain available through subsequent Init events. (open-mpi#13013) Signed-off-by: George Katevenis <gkatev@ics.forth.gr>
This was referenced Jan 8, 2025
hppritcha approved these changes Jan 8, 2025
Member
hppritcha left a comment
hppritcha left a comment There was a problem hiding this comment.
Thanks for adding the helpful comment section!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The MCA subsystem clears the storage of string variables at de-init. Keep the defaults for the mca vars in a secondary structure, so they remain available through subsequent Init events.
Fixes #13013, closes #13023.