request: correctly handle MPI_COMM_NULL #12944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ompi_request_check_same_instance(): ignore requests whose communicator is ompi_mpi_comm_null. That can occur when pml/ucx is used and mca_pml_ucx_completed_request_init() was invoked. Thanks Christian Huettig for the report and helping with the troubleshooting. Refs. open-mpi#12942 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Contributor Author
| FWIW, I think ompi/ompi/mca/pml/ucx/pml_ucx_request.c Line 285 in c6766bb |
janjust approved these changes Dec 10, 2024
devreal approved these changes Dec 10, 2024
Contributor
| @ggouaillardet is this still a draft? Can it be merged? |
Contributor Author
| @janjust sure, let's merge it! |
Contributor
| @ggouaillardet thanks! I opened the v5.0.x cherry-pick here: #12984 mind give it a quick thumbs up? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ompi_request_check_same_instance(): ignore requests whose communicator is ompi_mpi_comm_null. That can occur when pml/ucx is used and mca_pml_ucx_completed_request_init() was invoked.
Thanks Christian Huettig for the report and helping with the troubleshooting.
Refs. #12942