Fix mpirun.1.rst typos #12937
Merged
Fix mpirun.1.rst typos #12937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rhc54 requested changes Nov 26, 2024
Contributor
rhc54 left a comment
rhc54 left a comment There was a problem hiding this comment.
Few minor corrections. Do you also cover PMIx params in here somewhere? I didn't see them mentioned.
Fix some "PRRTE" typos (where they should be "PRTE"), and add some clarification language. Signed-off-by: Jeff Squyres <jeff@squyres.com>
Put MPI_COMM_WORLD in fixed-width font. Signed-off-by: Jeff Squyres <jeff@squyres.com>
jsquyres force-pushed the pr/mpirun.1-typo-fixes branch from 7506e84 to 724dd86 Compare Member Author
| Thanks @rhc54 -- fixed. |
rhc54 approved these changes Nov 26, 2024
Describe these options and recomend that users use them when passing PMIx and PRRTE MCA parameters, respectively. Signed-off-by: Jeff Squyres <jeff@squyres.com>
Member Author
| Hey @rhc54 -- I added blurbs about |
Contributor
Definitely!! Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thanks to @satishskamath for raising the issue.
Refs #12936
@rhc54 Can you confirm the PRRTE / PRTE fixes on this PR? (restricted to the 1st commit)