opal/mca/ofi: Patch series to fix a crash due to double free on error path #11744
Conversation
lrbison left a comment
lrbison left a comment There was a problem hiding this comment.
Thanks Wenduo. No issue with the changes, but two requests:
-
The double-free seems like it only happens on error path. Could you expend the existing commit message from just "bugfix" to something to that effect, or mention the function name. Bugfix isn't particularly helpful.
-
The rank issue seems to be more important to me. Seems like this PR's description should focus on that rather than the double-free.
I assume these problems were introduced recently and from the same PR, otherwise I would suggest separate PRs.
This patch fixes a bug in package rank calculation. The peer rank returned via PMIX_LOCAL_PEERS is the global rank. Matching it with local rank was wrong. Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
Fix a double free bug on the error path. This causes a harsh crash instead of returning an error code. Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
wenduwan changed the title 
| @lrbison Yes sir. Addressed. |
| @lrbison Can we merge? I think 1 review is good enough for this PR. |
| bot:ibm:retest |
| @gpaulsen Is it possible to share the IBM CI failure? Thanks |
| Sorry, the IBM failure appears to be a firewall issue on our end. Working to get it resolved soon. |
| bot:ibm:retest |
| IBM lab folks are still investigating the IBM CI failure this morning. |
| @gpaulsen Thank you. Please let me know if the issue is directly caused by this change. |
| @wenduwan it is not..it's a lab machine/hardware issue. |
| IBM CI is offline - please disregard the failures. We disabled our CI until the issues are resolved. |
| @lrbison Since we can bypass IBM CI, shall we merge this change? |
| Yes, merged. Thank you. |
4 participants
There is a bug in the current impl which attempts to compare local rank vs global rank. Furthermore, when this fails it triggers a double free on the error path, i.e. crash.
This change set addresss the root cause.