opal/common/ofi: match openfabrics device by uuid and osname #11728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This patch fixes a bug in device matching. uuid alone is not sufficient to match openfabrics devices, and therefore we need to also match osname. Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
Adjust string lengths according to the uuid format Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
Contributor Author
| @amirshehataornl Could you test out this change on your system and see if it breaks anything? |
lrbison approved these changes May 31, 2023
Contributor
| will test it today |
Contributor Author
| @amirshehataornl Did you have a chance to test it out? |
Contributor
| seems to work on my side |
Contributor Author
| @amirshehataornl Thank you! |
Contributor Author
| @hppritcha could you provide second opinions? The change is simple but I would appreciate your opinion. |
wzamazon approved these changes Jun 6, 2023
Contributor Author
| @hppritcha In case you missed this, could you please take a look? |
hppritcha approved these changes Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug in device matching. uuid alone is not sufficient to match openfabrics devices, and therefore we need to also match osname.