opal/ofi: package rank calculation bugfix #11693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The current implementation has an out-of-bound bug that process_info->my_local_rank could exceed package_ranks array length. This patch eliminates package_ranks array and fixes the bug. Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
lrbison reviewed May 18, 2023
Comment on lines +754 to +758
| | ||
| if ((uint16_t) pname.vpid == process_info->my_local_rank) { | ||
| return ranks_on_package; | ||
| } | ||
| |
Contributor
There was a problem hiding this comment.
This early return doesn't make sense to me. Can you explain?
Contributor
There was a problem hiding this comment.
nvm, I see it now, it reflects previous return value of package_ranks[process_info->my_local_rank];
Contributor
There was a problem hiding this comment.
OK, this makes sense to me, with the assumption that multiple peers cannot share the same vpid.
Contributor Author
There was a problem hiding this comment.
Yes. vpid is parsed from local_peers string in OPAL_MODEX_RECV_VALUE(rc, PMIX_LOCAL_PEERS, &pname, &local_peers, PMIX_STRING);
Based on my experiment, local_peers string should be the same for all local ranks, e.g. 0,5,3,6,2,1,4, each value mapping to a local rank id.
Contributor Author
| @lrbison Can we get this merged? |
lrbison approved these changes May 19, 2023
hppritcha approved these changes May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current implementation has an out-of-bound bug that process_info->my_local_rank could exceed package_ranks array length. This patch eliminates package_ranks array and fixes the bug.