Skip to content

ofi: Fix Coverity warnings #11659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023
Merged

ofi: Fix Coverity warnings #11659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opal/mca/common/ofi/common_ofi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,9 +651,9 @@ static bool is_near(pmix_device_distance_t *distances,
ret = sscanf(distances[i].uuid, "fab://%256s::%256s", lnguid, lsguid);
if (ret != 2)
continue;
if (0 == strcasecmp(lnguid, nguid)) {
if (nguid && (0 == strcasecmp(lnguid, nguid))) {
return true;
} else if (0 == strcasecmp(lsguid, sguid)) {
} else if (sguid && (0 == strcasecmp(lsguid, sguid))) {
return true;
}
}
Expand Down Expand Up @@ -789,7 +789,7 @@ struct fi_info *opal_common_ofi_select_provider(struct fi_info *provider_list,
struct fi_pci_attr pci;
int num_distances = 0;
#endif
bool near;
bool near = false;
int ret;
unsigned int num_provider = 0, provider_limit = 0;
bool provider_found = false;
Expand Down