This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Add new CLI options: timeout, get-stack-traces, report-state-on-timeout #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Test PASSed. |
| Test PASSed. |
| 👍 |
| Would you prefer to have these squashed to 1 commit, or keep them as two (first original from master and second fixes to make it work for v2.x)? |
| @jjhursey Thanks for asking. I like the trackability of the 2 commits: one directly traceable back to master is a Good Thing. |
| Ok - That sounds fine to me. So we'll leave it as two commits. I think this PR is ready to go once the RMs are ready for it. |
… timeout to assist with debugging Jenkins tests If requested, obtain stacktraces for each application process and report it to stderr upon timeout stack traces: minor improvements - Also include the hostname and PID of the each process for which we're sending the stack traces (vs. just including the ORTE process name) - Send a specific error message if we couldn't find "gstack" in the $PATH (e.g., on OS X) - Send a sepcific error message if gstack fails to run - Print a message that obtaining the stack traces may take a few seconds so that users don't wonder what's happening Signed-off-by: Jeff Squyres <jsquyres@cisco.com> help-orterun.txt: minor tweaks Trivial update: show "--timeout" (instead of "-timeout") in the help message, just to encourage the use of double-dash options. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> trivial: stacktrace -> stack trace Trivial word smything. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit ebe159a) -- Josh Hursey : Had to remove 2 conflict, which will be added back shortly * orte/orted/orted_submit.c * orte/orted/orted_submit.h
Three options introduced: * --timeout 2 * --get-stack-traces * --report-state-on-timeout
| Test PASSed. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Bring timeout feature introduced in open-mpi/ompi#1724 to the 2.x series. Target is 2.1.0 per the discussion on the original PR.
This required a bit of a custom patch due to architecture differences on master vs the 2.x series. I kept this as two commits to show what I changed. These should be squashed into commit once reviewed.
Three options introduced:
--timeout--get-stack-traces--report-state-on-timeoutbot:assign: @rhc54
bot:milestone:v2.1.0
bot:label:enhancement