- Notifications
You must be signed in to change notification settings - Fork 7
feat!: Spec v0.8 adherence #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
203e8da to 40d0812 Compare cabfae2 to 533f1ab Compare 16499c7 to 78a30e5 Compare ba7c072 to ac15098 Compare Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
76cd647 to eacbb12 Compare Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
eacbb12 to f1fe08f Compare
beeme1mr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fabriziodemaria, the change looks good from what I can tell (limited experience with Swift). Since this is a breaking change, it may be a good time to update the afterAll stage in the hooks to comply with a recent update to the spec.
https://openfeature.dev/specification/sections/hooks#requirement-438
This will make it easy to support more sophisticated telemetry use cases.
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
5da87b7 to 2c7886b Compare Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
17eeb61 to 81c9fa2 Compare | @nicklasl, any concerns with the PR? |
de12305 to 6981252 Compare Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
6981252 to 8e4e7eb Compare Just a minor README fix following up #46 Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.0](0.2.1...0.3.0) (2025-01-31) ### ⚠ BREAKING CHANGES * Spec v0.8 adherence ([#46](#46)) ### ✨ New Features * Spec v0.8 adherence ([#46](#46)) ([b6457f6](b6457f6)) ### 📚 Documentation * Fix spec version label in README ([#54](#54)) ([3e1ec5b](3e1ec5b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Spec v0.8 adherence
Ready,ErrororFatalare emitted by the SDK and are not expected by the Provider implementations.initializeandonContextChangeprotocols throwing, allowing for the OpenFeatureAPI layer to detect cases whereErrorevents should be emittedinitializeandonContextChangeprotocols async for an easier Provider implementation (in most cases)Missing parts
It's possible that the on context changed function is invoked simultaneously or in quick succession; in this case the SDK will only run the PROVIDER_CONTEXT_CHANGED handlers after all reentrant invocations have terminated, and the last to terminate was successful (terminated normally)Changes unrelated to Spec v0.8
setEvaluationContextAndWaitto provide the same better ergonomics thatsetProviderAndWaitalready offersafterAllhook to adhere to latest conventionsNotes on backwards compatibility
initialize()implementation needs to throw in case of errors, rather than emitting theERRORevent. The latter is now responsibility of the SDK. This is also valid foronContextChange.ERRORemission from the Provider side)Example Adoption
The Confidence OpenFeature Provider adopting this version of the SDK is in the works here: spotify/confidence-sdk-swift#184