Skip to content

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Oct 8, 2025

This PR

While sanity check the provider after first release, this fixes the unresolvable export of the provider.
Besides that - locally tested - all functionalities work as expected.

  • Changed export default class to export class FlagsmithOpenFeatureProvider -> index file doesn't re-export default
  • Updated README examples to use named imports
  • Exported FlagsmithProviderConfig interface

Related Issues

Notes

Follow-up Tasks

How to test

Follow the Readme steps

@Zaimwa9 Zaimwa9 requested review from a team as code owners October 8, 2025 14:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Zaimwa9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an export issue with the FlagsmithOpenFeatureProvider by converting it from a default export to a named export. This change ensures the provider is correctly resolvable. Corresponding updates were made to the README.md documentation and the provider's test file (flagsmith-provider.spec.ts) to use the new named import syntax. Additionally, the FlagsmithProviderConfig interface is now exported, making it accessible for external use.

Highlights

  • Intent: This PR fixes an issue where the FlagsmithOpenFeatureProvider was unresolvable due to being exported as a default export. It changes the provider to a named export, updates all references (including documentation and tests) to use named imports, and also exports the FlagsmithProviderConfig interface for broader use.
  • Key Changes: The FlagsmithOpenFeatureProvider class in flagsmith-provider.ts was changed from a default export to a named export. The FlagsmithProviderConfig interface in the same file is now explicitly exported. The README.md and flagsmith-provider.spec.ts files were updated to reflect these changes by using named imports for FlagsmithOpenFeatureProvider and Flagsmith.
  • Reviewer Activity: No specific reviewer activity was noted in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: wadii <wadii.zaim@flagsmith.com>
@Zaimwa9 Zaimwa9 force-pushed the fix/flagsmith-provider-export branch from dc8078a to 8a63495 Compare October 8, 2025 14:54
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request has been reviewed and the following comments are provided to help improve the code.

@beeme1mr beeme1mr changed the title fix: named-export-provider-and-doc-update fix: named export provider Oct 8, 2025
@beeme1mr beeme1mr merged commit f001d23 into open-feature:main Oct 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants