feat: support no default variant #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
toddbaert changed the title toddbaert force-pushed the feat/support-no-defaultVariant branch from bf8aa2c to 324c709 Compare toddbaert force-pushed the feat/support-no-defaultVariant branch from 324c709 to 9d4769a Compare 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert force-pushed the feat/support-no-defaultVariant branch from 9d4769a to a8bc4a4 Compare 
toddbaert commented Jul 15, 2025
Comment on lines +67 to +70
| then(/^the error-code should be "(.*)"$/, (expectedError: keyof typeof ErrorCode) => { | ||
| expect(state.details?.errorCode).toBe(ErrorCode[expectedError]); | ||
| }); | ||
| |
There was a problem hiding this comment.
New binding for updated gherkin suite: open-feature/flagd-testbed@d31f2f9
chrfwow approved these changes Jul 16, 2025
aepfli approved these changes Jul 16, 2025
This was referenced Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Supports no
defaultVariant, as per gherkin additions.Fixes: #1322