Skip to content

fix(gofeatureflag): Fix NPE when error code is not set in the API response #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix(gofeatureflag): Fix NPE when error code is not set in the API response #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8116ab
fix(gofeatureflag): Fix NPE when error code is not set in the API res…
thomaspoignant Jul 1, 2024
c6fa1fd
fix: use isEmpty and not equals
thomaspoignant Jul 2, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...a/dev/openfeature/contrib/providers/gofeatureflag/controller/GoFeatureFlagController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public <T> EvaluationResponse<T> evaluateFlag(
requestMapper.writeValueAsBytes(goffRequest),
MediaType.get("application/json; charset=utf-8")));

if (this.apiKey != null && !"".equals(this.apiKey)) {
if (this.apiKey != null && !this.apiKey.isEmpty()) {
reqBuilder.addHeader(HttpHeaders.AUTHORIZATION, BEARER_TOKEN + this.apiKey);
}

Expand Down Expand Up @@ -299,6 +299,10 @@ public ConfigurationChange configurationHasChanged() throws GoFeatureFlagExcepti
* @return an item from the enum
*/
private ErrorCode mapErrorCode(String errorCode) {
if (errorCode == null || errorCode.isEmpty()) {
return null;
}

try {
return ErrorCode.valueOf(errorCode);
} catch (IllegalArgumentException e) {
Expand Down
18 changes: 18 additions & 0 deletions .../test/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,24 @@ void should_resolve_a_valid_boolean_flag_with_TARGETING_MATCH_reason() {
assertEquals(want, got);
}

@SneakyThrows
@Test
void should_resolve_a_valid_boolean_flag_with_TARGETING_MATCH_reason_without_error_code_in_payload() {
GoFeatureFlagProvider g = new GoFeatureFlagProvider(GoFeatureFlagProviderOptions.builder().endpoint(this.baseUrl.toString()).timeout(1000).build());
String providerName = this.testName;
OpenFeatureAPI.getInstance().setProviderAndWait(providerName, g);
Client client = OpenFeatureAPI.getInstance().getClient(providerName);
FlagEvaluationDetails<Boolean> got = client.getBooleanDetails("bool_targeting_match_no_error_code", false, this.evaluationContext);
FlagEvaluationDetails<Boolean> want = FlagEvaluationDetails.<Boolean>builder()
.value(true)
.variant("True")
.flagKey("bool_targeting_match_no_error_code")
.reason(Reason.TARGETING_MATCH.name())
.flagMetadata(defaultMetadata)
.build();
assertEquals(want, got);
}

@SneakyThrows
@Test
void should_resolve_a_valid_boolean_flag_with_TARGETING_MATCH_reason_cache_disabled() {
Expand Down
13 changes: 13 additions & 0 deletions ...go-feature-flag/src/test/resources/mock_responses/bool_targeting_match_no_error_code.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"trackEvents": true,
"variationType": "True",
"failed": false,
"version": 0,
"reason": "TARGETING_MATCH",
"value": true,
"cacheable": true,
"metadata": {
"pr_link": "https://github.com/thomaspoignant/go-feature-flag/pull/916",
"version": 1
}
}