Skip to content

chore: add tobuilder test #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

chore: add tobuilder test #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,33 @@ void testValueProviderForEdgeCase_invalid() {
assertEquals(Config.DEFAULT_RESOLVER_TYPE, Config.fromValueProvider(dummy));
}

@Test
void toBuilder_maintains_props() {
String selector = "some-selector";
int port = 1337;
int gracePeriod = 33;
int keepAlive = 9000;

FlagdOptions options = FlagdOptions.builder()
.resolverType(Resolver.IN_PROCESS)
.port(port)
.selector(selector)
.keepAlive(keepAlive)
.build();

FlagdOptions rebuiltOptions =
options.toBuilder().retryGracePeriod(gracePeriod).build();

// old props
assertEquals(selector, rebuiltOptions.getSelector());
assertEquals(port, rebuiltOptions.getPort());
assertEquals(keepAlive, rebuiltOptions.getKeepAlive());
assertEquals(Resolver.IN_PROCESS, rebuiltOptions.getResolverType());

// added props
assertEquals(gracePeriod, rebuiltOptions.getRetryGracePeriod());
}

@Test
@SetEnvironmentVariable(key = RESOLVER_ENV_VAR, value = RESOLVER_IN_PROCESS)
void testInProcessProviderFromEnv_noPortConfigured_defaultsToCorrectPort() {
Expand Down
Loading