Skip to content

Conversation

Rahul-Baradol
Copy link
Member

This PR

  • supports missing/null default values, by returning FLAG_NOT_FOUND,
    • for flag configurations missing a defaultValue, and
    • for which targeting doesn't resolve a variant and there is no defaultValue

Related Issues

Fixes #1438

Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Copy link
Member

@guidobrei guidobrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Rahul-Baradol.
I've added some comments on things that cached my attention.

Wondreing what the Gherkin tests will reveal.

@toddbaert
Copy link
Member

@Rahul-Baradol if it's any help, here is my JS implementation of the same thing. I'm happy to add the e2e tests here once your implementation is complete, so you can ignore that part.

@beeme1mr beeme1mr changed the title feat!: allowing null/missing default values feat: allowing null/missing default values Jul 16, 2025
@beeme1mr
Copy link
Member

FYI, I've updated the title to remove the ! since this isn't a breaking change.

aepfli added 2 commits July 23, 2025 11:42
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
Copy link
Member

aepfli commented Jul 23, 2025

@Rahul-Baradol i hope you dont mind me fixing your conflict, and activating our e2e test suite for your feature. Now this code runs against the e2e tests which we are also using in other languages.

@Rahul-Baradol
Copy link
Member Author

Sure, I don't have issues !

Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
@aepfli aepfli merged commit 229ddcb into open-feature:main Jul 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

8 participants