This repository was archived by the owner on Jan 18, 2022. It is now read-only.
Generate the CAIDA data timestamp based on the current month #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bassosimone suggested changes Jan 14, 2021
generator_ripe_caida.sh Outdated
| | ||
| tstamp=$(date +%Y%m%d%H%M%S) | ||
| caida_tstamp=20201001 | ||
| caida_tstamp=$(date +%Y%m%01) |
There was a problem hiding this comment.
This would break because they don't update monthly. We need a smarter logic here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Good call. I will take another stab at this.
There was a problem hiding this comment.
Even if we were to update monthly, we need to manage race conditions around the time of publishing from Caida
There was a problem hiding this comment.
How frequently is the github action run?
There was a problem hiding this comment.
There was a problem hiding this comment.
(After a few weeks of inactivity, GH disables automatic runs)
| @hellais "this should work until 2099" makes me think of:
|
bassosimone approved these changes Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds support for getting always the latest CAIDA AS name data