Support for more TensorScatter* operations #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added support for TensorScatterMax, TensorScatterMin and TensorScatterSub. Added tests for all TensorScatter* operations. Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Signed-off-by: Javier Dehesa <javidcf@gmail.com>
fatcat-z reviewed May 26, 2023
fatcat-z reviewed May 26, 2023
tf.tensor_scatter_nd_update and tf.tensor_scatter_nd_add already tested elsewhere. Signed-off-by: Javier Dehesa <javidcf@gmail.com>
fatcat-z reviewed May 26, 2023
fatcat-z reviewed May 26, 2023
fatcat-z reviewed May 26, 2023
Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Contributor Author
| Seems there was some issue with Azure in the failing checks above. Can those be retried @fatcat-z ? |
fatcat-z approved these changes May 29, 2023
Collaborator
fatcat-z left a comment
fatcat-z left a comment There was a problem hiding this comment.
LGTM, thanks for your contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added support for TensorScatterMax, TensorScatterMin and TensorScatterSub.
Added tests for all TensorScatter* operations.