Transpose optimization for Softmax and LogSoftmax (fixes #1716) #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In opsets 13 and higher, the axis of the operation is arbitrary and can simply be changed according to the permutation of the Transpose. In lower opsets, Softmax always coerces its inputs to a 2D tensor, making Transpose operations necessary if the permutation moves axes between the coerced batch and feature dimensions. Signed-off-by: fthielke <fthielke@fb3.uni-bremen.de>
janbernloehr force-pushed the softmax_transpose_opt2 branch 2 times, most recently from c8440da to a2e40fb Compare 
Signed-off-by: janbernloehr <jan@bernloehrs.de>
janbernloehr force-pushed the softmax_transpose_opt2 branch from a2e40fb to f512d32 Compare 
Contributor Author
| @fatcat-z , @TomWildenhain-Microsoft : Maybe you can take another look. pylint issues have been fixed. |
fatcat-z approved these changes Jun 11, 2022
Collaborator
fatcat-z left a comment
fatcat-z left a comment There was a problem hiding this comment.
LGTM, thanks for your contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is reopening #1727 by @fthielke to fix the remaining issues to get it merged.
Original Description
In opsets 13 and higher, the axis of the operation is arbitrary and can simply be changed according to the permutation of the Transpose.
In lower opsets, Softmax always coerces its inputs to a 2D tensor, making Transpose operations necessary if the permutation moves axes between the coerced batch and feature dimensions.