Bugfix for concatenating node instead of str. #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Di Natale <frank.dinatale1988@gmail.com>
fatcat-z approved these changes May 16, 2022
Collaborator
fatcat-z left a comment
fatcat-z left a comment There was a problem hiding this comment.
LGTM, thanks for your contribution.
hwangdeyu pushed a commit to hwangdeyu/tensorflow-onnx that referenced this pull request May 23, 2022
Signed-off-by: Francesco Di Natale <frank.dinatale1988@gmail.com> Co-authored-by: Jay Zhang <36183870+fatcat-z@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are two exceptions that attempt to concatenate a node to the exception string. This PR simply calls into the name property to get the node name out.