Change package author #1885
Merged
Change package author #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fatcat-z reviewed Mar 22, 2022
Contributor
| It should be signed off for each of commit in tf2onnx. |
hwangdeyu approved these changes Mar 23, 2022
Contributor
hwangdeyu left a comment
hwangdeyu left a comment There was a problem hiding this comment.
LGTM. Please fix CI DCO required. Thanks!
Microsoft doesn't author this package, the ONNX community does. Copied from onnx/onnx: https://github.com/onnx/onnx/blob/acc127219b45bc27b0180b1fdc08299eac81b167/setup.py#L342 Signed-off-by: Gary Miguel <garymiguel@microsoft.com>
Signed-off-by: Gary Miguel <garymiguel@microsoft.com>
Contributor Author
| DCO check passed. Please merge. Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Microsoft doesn't author this package, the ONNX community does.
Copied from onnx/onnx:
https://github.com/onnx/onnx/blob/acc127219b45bc27b0180b1fdc08299eac81b167/setup.py#L342