Skip to content

Change custom op example to new API and add the doc #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hwangdeyu merged 4 commits into from
Apr 20, 2022
Merged

Change custom op example to new API and add the doc #1883

hwangdeyu merged 4 commits into from
Apr 20, 2022

Conversation

@hwangdeyu
Copy link
Contributor

@hwangdeyu hwangdeyu commented Mar 21, 2022

fixes #1852

Signed-off-by: Deyu Huang deyhuang@microsoft.com
hwangdeyu
hwangdeyu commented Mar 24, 2022
View reviewed changes
examples/tf_custom_op/custom_op.md
@@ -0,0 +1,156 @@
<!--- SPDX-License-Identifier: Apache-2.0 -->
Copy link
Contributor Author

@hwangdeyu hwangdeyu Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EmmaNingMS, do you have any comment for this tf custom op conversion doc?
hwangdeyu added 2 commits April 7, 2022 20:22
@hwangdeyu
change example to new api and add the doc
6a780e8 
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
@hwangdeyu
add more details and changes
ce749ce 
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
hwangdeyu
hwangdeyu commented Apr 7, 2022
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2022

This pull request introduces 1 alert and fixes 1 when merging ce749ce into 07e9e0f - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'
fatcat-z
fatcat-z reviewed Apr 20, 2022
View reviewed changes
fatcat-z
fatcat-z approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@lgtm-com
Copy link

lgtm-com bot commented Apr 20, 2022

This pull request introduces 1 alert and fixes 1 when merging bdd0cd4 into 18ebae1 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'
@hwangdeyu
fix typo
5f9b7c8 
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 20, 2022

This pull request fixes 1 alert when merging 5f9b7c8 into 18ebae1 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'
@hwangdeyu hwangdeyu enabled auto-merge (rebase) April 20, 2022 08:05
@hwangdeyu hwangdeyu disabled auto-merge April 20, 2022 09:30
@hwangdeyu hwangdeyu enabled auto-merge (squash) April 20, 2022 09:31
@hwangdeyu hwangdeyu disabled auto-merge April 20, 2022 09:31
@hwangdeyu hwangdeyu enabled auto-merge (squash) April 20, 2022 09:32
@lgtm-com
Copy link

lgtm-com bot commented Apr 20, 2022

This pull request fixes 1 alert when merging a2ad51c into 18ebae1 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'
@hwangdeyu hwangdeyu merged commit 2d29fbd into onnx:main Apr 20, 2022
@hwangdeyu hwangdeyu deleted the custom_op_doc branch April 21, 2022 02:38
@hwangdeyu hwangdeyu mentioned this pull request Apr 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hwangdeyu @fatcat-z