Skip to content

Conversation

@marekkozl
Copy link
Contributor

No description provided.

@marekkozl marekkozl force-pushed the marekkoz/lzt-macros branch 3 times, most recently from 9988fd5 to aefd12a Compare May 29, 2025 11:00
@marekkozl marekkozl requested a review from Copilot May 29, 2025 11:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates existing Google Test cases to use the custom LZT test macros and result-checking helpers, and updates build configuration accordingly.

  • Replace all TEST/TEST_F/TEST_P with LZT_TEST/LZT_TEST_F/LZT_TEST_P and swap EXPECT_EQ/ASSERT_EQ on ZE_RESULT_SUCCESS to EXPECT_ZE_RESULT_SUCCESS/ASSERT_ZE_RESULT_SUCCESS.
  • Update CMake setup: bump minimum CMake version, set C++17 standard, include gtest_setup.cmake, and add level_zero_tests::utils to test targets.
  • Adjust GitHub workflows: remove standalone build-quick.yml, integrate quick build into build-multi.yml, and add job dependencies.

Reviewed Changes

Copilot reviewed 177 out of 177 changed files in this pull request and generated no comments.

File Description
conformance_tests/core/test_device/src/test_device.cpp Converted TEST macros to LZT_TEST and updated result assertions
conformance_tests/core/test_cmdqueue/src/test_cmdqueue.cpp Swapped TEST_F to LZT_TEST_F, replaced result checks with custom macros
cmake/gtest_setup.cmake Introduced definitions to prevent GTest from redefining TEST macros
CMakeLists.txt Bumped CMake minimum version, set C++ standard to 17, included gtest setup
Comments suppressed due to low confidence (1)

conformance_tests/core/test_cmdqueue/src/test_cmdqueue.cpp:494

  • The test name has a typo: 'Sucess' should be 'Success'.
GivenDefaultFlagInCommandListWhenCommandQueueFlagisExplicitOnlyThenSucessIsReturned) { 
@marekkozl marekkozl force-pushed the marekkoz/lzt-macros branch 2 times, most recently from a85f598 to c291d0c Compare May 29, 2025 11:50
Copy link
Contributor

@gwawiork gwawiork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Minor - good to know why this step and script is needed - lzt_gtest_scan.py

darmroz
darmroz previously approved these changes Jun 12, 2025
* apply skipping mechanism with `LztGtestSkipExectuionException` * add `ASSERT_ZE_RESULT_SUCCESS` macro * add `EXPECT_ZE_RESULT_SUCCESS` macro * add static validation for test suites * add prefixed `LZT_` custom gtest macros * update minimum required cmake version to `3.12.0` Signed-off-by: Kozlowski, Marek <marek.kozlowski@intel.com>
Signed-off-by: Kozlowski, Marek <marek.kozlowski@intel.com>
* force new macros usage * add guard macro script to infrastructure Signed-off-by: Kozlowski, Marek <marek.kozlowski@intel.com>
@marekkozl marekkozl force-pushed the marekkoz/lzt-macros branch from 1e913ad to 1869400 Compare June 23, 2025 05:16
@marekkozl marekkozl merged commit f64af6a into oneapi-src:master Jun 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants