- Notifications
You must be signed in to change notification settings - Fork 177
dark/light body class #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Fil wants to merge 12 commits into main Choose a base branch from fil/dark-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
dark/light body class #1780
Changes from 1 commit
Commits
Show all changes
12 commits Select commit Hold shift + click to select a range
eb0be3c dark/light body class
Fil 907a7cb fix tests
Fil 7bdfd5a Merge branch 'main' into fil/dark-class
Fil 90fa91a common dark
Fil 6decacf fix comment
Fil c0ba454 redacted script, optimized
Fil afa6703 fix tests
Fil 43074b3 semicolon
Fil bcab913 dark.js ; use color not background-color
Fil 9d0cdfd fix tests
Fil d3498b9 avoid top-level await
mbostock 38e47e7 revert changes in dark()
Fil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
common dark
- Loading branch information
commit 90fa91a01e30dc18d1df3bb9040e8b8a56a0bbe2
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,21 @@ | ||
| import {observe} from "./observe.js"; | ||
| | ||
| // Watches dark mode based on theme and user preference. | ||
| // TODO: in preview, also watch for changes in the theme meta. | ||
| // Watches dark mode based on the color-scheme property, that the chosen theme | ||
| // sets. | ||
| export function dark() { | ||
| return observe((notify: (dark: boolean) => void) => { | ||
| let dark: boolean | undefined; | ||
| const media = matchMedia("(prefers-color-scheme: dark)"); | ||
| const probe = document.createElement("div"); | ||
| probe.style.setProperty("transition-property", "background-color"); | ||
| probe.style.setProperty("transition-duration", "0.001s"); | ||
| const changed = () => { | ||
| const d = getComputedStyle(document.body).getPropertyValue("color-scheme") === "dark"; | ||
| const d = getComputedStyle(probe).getPropertyValue("color-scheme") === "dark"; | ||
| if (dark === d) return; // only notify if changed | ||
| notify((dark = d)); | ||
| }; | ||
| document.body.append(probe); | ||
| probe.addEventListener("transitionstart", changed); | ||
| changed(); | ||
| media.addEventListener("change", changed); | ||
| return () => media.removeEventListener("change", changed); | ||
| return () => probe.remove(); | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.