WIP - property query dart26 #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… e.g. "<T extends Base>") * Replaced propertyX with generic property method (with auto-type inference) * Added default to find functions, should the default arg value be 0 or should the address be 0 for NULL? It would be nice to see the actual (closed) source code in this "open" source project.
We could have used extension methods to fix it without changing too many lines of code
replace allocate/free with package:ffi's
used asTypedList properly
since there is no clear connection between the alloc of Uint8 and the Utf8 Struct At least we can generate, compile, run all the tests
Test integer limits
Test null values for entity properties
v0.4.0 release
everything else (e.g. count) is still horribly broken
seems to return a result before the search is actually concluded, there is some non-deterministic behavior here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I need suggestions for fixing #70