[onefetch.dev] switch to dark theme #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
o2sh changed the title | "check:svelte": "svelte-check", | ||
| "check:prettier": "prettier --check **/*.{ts,js,svelte,css,html,json}", | ||
| "check:lint": "eslint 'src/**/*.{ts,js,svelte}'" | ||
| "check:lint": "eslint src/**/*.{ts,js,svelte}" |
There was a problem hiding this comment.
I forget exactly why this nuance is important, but quoting the glob ensures that eslint receives it as a string instead of the glob getting expanded to several arguments IIRC
There was a problem hiding this comment.
With the quotes, i was getting the following error: ""No files matching the pattern "'src/**/*.{ts,js,svelte}'" were found.""
| @@ -1,3 +1,4 @@ | |||
| /* $color-text: #dedce5; */ | |||
There was a problem hiding this comment.
Was this file manually edited, or did you grab one of the other stylesheets?
There was a problem hiding this comment.
I overrode it with https://github.com/oxalorg/sakura/blob/master/css/sakura-dark.css
There was a problem hiding this comment.
I renamed the css file to sakura-dark.css
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
spenserblack approved these changes Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Switching to a dark theme to make the site easier on the eyes,