Initial selectorified API #2567
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have here a skeleton API for a selectorified API. This begins to address #2543 and #2545 (Perhaps? Comments?) by switching from the API used in
o1vm/src/mips/interpreter.rsto that detailed ino1vmsrc/mips/singlestep.rs.The main changes are:
a -> State -> (b, State)enumfields with them. This allows the generator style to uniformly look likeInstructions -> State -> (Witness, State)and for witness generation, without having to worry about different arities and register arguments. [Of course, the old instructions with their arguments can be relatively easily converted to this form -- to come].ExampleSpreviously an implementor ofInterpreterEnv(Envinwitness.rsand the like) which will almost surely grow as the number of instructions returns to parity.The point of these changes is to provide a basic test-bed for the selector changes to come.