Skip to content

Conversation

@jiriks74
Copy link
Contributor

Fixes #15

@tomodachi94
Copy link
Member

I don't think we should format with StyLua, as it would hinder attempts to merge changes to/from upstream.

@tomodachi94
Copy link
Member

I'm wondering if we should close this project and submit all of its fixes upstream?

@jiriks74
Copy link
Contributor Author

jiriks74 commented Oct 28, 2024

as it would hinder attempts to merge changes to/from upstream

Fair enough I can revert that change if needed then.

I'm wondering if we should close this project and submit all of its fixes upstream?

I think that it's a good idea if it's still maintained. It doesn't make sense to maintain 2 versions of this if the upstream is maintained and accepts changes.

I can make a PR there if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants