Skip to content

Conversation

melissawm
Copy link
Member

@melissawm melissawm commented Apr 5, 2021

- Fixed README and index.md wording - Moved images for consistency across binder and html site - Added alt text where appropriate - Removed workaround for numpygh-63
@melissawm melissawm marked this pull request as ready for review April 5, 2021 19:49
Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM - big +1 on moving the non-generated images/gifs/etc. to a static folder. However, by using the _static folder inside the site directory, the relative links (e.g. [img](../_static/...) will only work for the generated site. If a user tries to open a tutorial locally w/ jupyter notebook, the images won't be found.

I would recommend creating another _static directory in content for all of the .pngs and .gifs linked to by the tutorials themselves (site/_static contains resources only for the portions of the site that are not meant to be opened in jupyter-notebook, e.g. index.md).

I'd be happy to take a stab at that if you'd like, just LMK!

@melissawm
Copy link
Member Author

I would recommend creating another _static directory in content for all of the .pngs and .gifs linked to by the tutorials themselves (site/_static contains resources only for the portions of the site that are not meant to be opened in jupyter-notebook, e.g. index.md).

That's absolutely right and something I overlooked at first, thanks!

Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @melissawm !

The CI failure is unrelated to these changes.

@rossbar rossbar merged commit 103bd9f into numpy:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants