feat: implement Update/Delete APIs with enhanced security #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR completes Issue #107 by implementing PUT and DELETE endpoints for the /api/gists/[id] route with comprehensive security features and API test refactoring. ## Key Features ### DELETE Endpoint - Dual authentication methods: - One-time view gists: metadata proof validation (SHA-256 hash) - PIN-protected gists: PIN validation via X-Edit-Password header - CSRF protection on all state-changing endpoints - Fixed race condition by moving auto-deletion to explicit DELETE endpoint ### PUT Endpoint - Multipart form data support for gist updates - PIN validation for protected gists - Optimistic locking to prevent concurrent update conflicts - Support for updating encrypted user metadata and editor preferences ### Security Enhancements - Created reusable CSRF validation in lib/security.ts - Converted all crypto operations to WebCrypto API for edge runtime - Added comprehensive schema validation using Zod - Proper error handling with typed AppError system ### API Test Refactoring - Established consistent test pattern: route.{method}.test.ts - Split all combined test files by HTTP method - Created API_TEST_PATTERN.md documentation - All 69 tests passing with 100% coverage ### Additional Improvements - Implemented user metadata encryption support - Created shared schemas in lib/api-schemas.ts - Added editor preferences to create/update operations - Updated tracking documents and TODO.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | ghostpaste | cdc8560 | Visit preview | Jun 08 2025, 01:50 AM |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code