Skip to content

Conversation

jhadev
Copy link
Collaborator

@jhadev jhadev commented May 31, 2022

Might need another eye both with output and presentation but it works well for me.
Thanks,
Josh

Was going for this -
https://developer.mozilla.org/en-US/docs/Web/API/Resource_Timing_API/Using_the_Resource_Timing_API#timing_resource_loading_phases

@jhadev jhadev added the enhancement New feature or request label May 31, 2022
@jhadev jhadev requested a review from nucliweb May 31, 2022 18:43
@@ -0,0 +1 @@
testing.js No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a test script?
Perhaps it would be interesting to have a test script, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a test script I use to stay organized before it goes into the readme, its full of comments of dead code or changes i wanted to revisit.

@nucliweb
Copy link
Owner

nucliweb commented Jun 1, 2022

I can see that this PR change some code's syntax, we can add a linter rules to have the same rules when we ara working in this project. What do you think @jhadev?

@nucliweb nucliweb merged commit 005da79 into main Jun 1, 2022
@nucliweb nucliweb deleted the first-third-extra branch June 1, 2022 10:09
@jhadev
Copy link
Collaborator Author

jhadev commented Jun 1, 2022

I can see that this PR change some code's syntax, we can add a linter rules to have the same rules when we ara working in this project. What do you think @jhadev?

Yes that was my fault. I used a different formatter by accident. The linter is up to you, I'm not sure what caused this. I always use prettier though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

2 participants