Skip to content

feat: Add support for .mlpackage formal models #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add support for .mlpackage formal models #2

wants to merge 1 commit into from

Conversation

@andrewginns
Copy link

@andrewginns andrewginns commented Feb 11, 2024 •
edited
Loading

Disclaimer: I've never written a line of Swift or followed a tutorial on it in my life. This code was developed with the help of gpt-4-turbo-0125 and compiles and runs on XCode 15.2.

Changes

  1. Added support for .mlpackage alongside the already supported .mlmodel file format.
    • Added file format information to info.plist
    • Added UTType for the .mlpackage to Constants.swift
  2. Fixed a compilation error Initializer for conditional binding must have Optional type, not CGRect in DetectionView.swift on GeometryReader
    • Directly use the result of getVideoRect without conditional binding

Testing

Tested with a yolov8x.mlpackage generated using yolo export model=yolov8x.pt format=coreml nms=true through the latest ultralytics package

Built Application

My unofficial version 1.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@andrewginns