fix: better handling of whitespace (backport to v5) #585
+156 −27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joaomoreno force-pushed the joao/backport-564-to-v5 branch from 0572517 to 57bfd39 Compare 
| #580 should be fixed before we go backporting anything so we don't bring new bugs along. |
| #587 Also needs to be fixed |
lukekarrys force-pushed the release/v5 branch 2 times, most recently from b67c2f8 to deb5ad5 Compare 
| the latest template-oss changes have been applied to |
lukekarrys force-pushed the joao/backport-564-to-v5 branch from 74351cf to d4530b8 Compare | @joaomoreno i was able to push to your branch with the relevant commits. waiting on CI to see if tests pass in older versions of node |
lukekarrys changed the title 1 task
| Sounds good, thanks @lukekarrys! |
wraithgar approved these changes Jul 10, 2023
Merged
| I've opened github/advisory-database#2483 updating the advisory for v5 |
| and I've opened github/advisory-database#2484 updating the advisory again for v6 and v5. |
| Thanks @G-Rath! |
| Thanks all! |
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Nov 6, 2024
This was referenced Jan 28, 2025
This was referenced Feb 10, 2025
Open
This was referenced Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This backports the security fix #564 to v5.